|
|
Descriptionfix highbit video
My recent cl for implementing 12-bit video broke re-drawing of highbit video layers.
This is because the resource has to be marked with the right multiplier & offset every time,
even if we're re-using the texture. This fixes that.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/a14c49913f865eabc5b2a22ed97dc6ab49ff4d18
Cr-Commit-Position: refs/heads/master@{#423382}
Patch Set 1 #
Total comments: 2
Patch Set 2 : test added, comment addressed #
Total comments: 2
Patch Set 3 : comment added #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. ========== to ========== fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
hubbe@chromium.org changed reviewers: + danakj@chromium.org
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Can unit test? https://codereview.chromium.org/2395943002/diff/1/cc/resources/video_resource... File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/2395943002/diff/1/cc/resources/video_resource... cc/resources/video_resource_updater.cc:578: // then we used the OR path below, which means that we need to comment wrong now
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Can haz test. https://codereview.chromium.org/2395943002/diff/1/cc/resources/video_resource... File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/2395943002/diff/1/cc/resources/video_resource... cc/resources/video_resource_updater.cc:578: // then we used the OR path below, which means that we need to On 2016/10/05 23:20:01, danakj wrote: > comment wrong now Done.
https://codereview.chromium.org/2395943002/diff/20001/cc/resources/video_reso... File cc/resources/video_resource_updater_unittest.cc (right): https://codereview.chromium.org/2395943002/diff/20001/cc/resources/video_reso... cc/resources/video_resource_updater_unittest.cc:283: VideoFrameExternalResources resources2 = What's this 2nd case testing that's diffrent?
Description was changed from ========== fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
https://codereview.chromium.org/2395943002/diff/20001/cc/resources/video_reso... File cc/resources/video_resource_updater_unittest.cc (right): https://codereview.chromium.org/2395943002/diff/20001/cc/resources/video_reso... cc/resources/video_resource_updater_unittest.cc:283: VideoFrameExternalResources resources2 = On 2016/10/06 00:19:06, danakj wrote: > What's this 2nd case testing that's diffrent? Comment added.
Thanks! LGTM
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/a14c49913f865eabc5b2a22ed97dc6ab49ff4d18 Cr-Commit-Position: refs/heads/master@{#423382} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a14c49913f865eabc5b2a22ed97dc6ab49ff4d18 Cr-Commit-Position: refs/heads/master@{#423382} |