Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2395943002: fix highbit video (Closed)

Created:
4 years, 2 months ago by hubbe
Modified:
4 years, 2 months ago
Reviewers:
danakj
CC:
chromium-reviews, posciak+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix highbit video My recent cl for implementing 12-bit video broke re-drawing of highbit video layers. This is because the resource has to be marked with the right multiplier & offset every time, even if we're re-using the texture. This fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/a14c49913f865eabc5b2a22ed97dc6ab49ff4d18 Cr-Commit-Position: refs/heads/master@{#423382}

Patch Set 1 #

Total comments: 2

Patch Set 2 : test added, comment addressed #

Total comments: 2

Patch Set 3 : comment added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M cc/resources/video_resource_updater.cc View 1 2 chunks +29 lines, -28 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
hubbe
4 years, 2 months ago (2016-10-05 23:06:55 UTC) #3
danakj
Can unit test? https://codereview.chromium.org/2395943002/diff/1/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/2395943002/diff/1/cc/resources/video_resource_updater.cc#newcode578 cc/resources/video_resource_updater.cc:578: // then we used the OR ...
4 years, 2 months ago (2016-10-05 23:20:01 UTC) #6
hubbe
Can haz test. https://codereview.chromium.org/2395943002/diff/1/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/2395943002/diff/1/cc/resources/video_resource_updater.cc#newcode578 cc/resources/video_resource_updater.cc:578: // then we used the OR ...
4 years, 2 months ago (2016-10-06 00:16:30 UTC) #11
danakj
https://codereview.chromium.org/2395943002/diff/20001/cc/resources/video_resource_updater_unittest.cc File cc/resources/video_resource_updater_unittest.cc (right): https://codereview.chromium.org/2395943002/diff/20001/cc/resources/video_resource_updater_unittest.cc#newcode283 cc/resources/video_resource_updater_unittest.cc:283: VideoFrameExternalResources resources2 = What's this 2nd case testing that's ...
4 years, 2 months ago (2016-10-06 00:19:07 UTC) #12
hubbe
https://codereview.chromium.org/2395943002/diff/20001/cc/resources/video_resource_updater_unittest.cc File cc/resources/video_resource_updater_unittest.cc (right): https://codereview.chromium.org/2395943002/diff/20001/cc/resources/video_resource_updater_unittest.cc#newcode283 cc/resources/video_resource_updater_unittest.cc:283: VideoFrameExternalResources resources2 = On 2016/10/06 00:19:06, danakj wrote: > ...
4 years, 2 months ago (2016-10-06 00:21:51 UTC) #15
danakj
Thanks! LGTM
4 years, 2 months ago (2016-10-06 00:22:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395943002/40001
4 years, 2 months ago (2016-10-06 00:25:57 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 01:34:36 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 01:38:51 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a14c49913f865eabc5b2a22ed97dc6ab49ff4d18
Cr-Commit-Position: refs/heads/master@{#423382}

Powered by Google App Engine
This is Rietveld 408576698