chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc - Issue 2395903002: API changes to support suspending requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Issue 2395903002: API changes to support suspending requests (Closed)

Patch Set: Keep the JS with a boolean instead of forcing a double. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | components/offline_pages/background/request_coordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

index bddeb65a6fa1d8cd5f68d83afe284786ba5c1bbb..993c6eee2a86abe9351dff5bba60b9442b850745 100644

--- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

+++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

@@ -287,9 +287,10 @@ void OfflineInternalsUIMessageHandler::HandleAddToRequestQueue(

ResolveJavascriptCallback(

*callback_id,

base::FundamentalValue(request_coordinator_->SavePageLater(

- GURL(url), offline_pages::ClientId(offline_pages::kAsyncNamespace,

- id_stream.str()),

- true)));

+ GURL(url), offline_pages::ClientId(

+ offline_pages::kAsyncNamespace, id_stream.str()),

+ true, offline_pages::RequestCoordinator::RequestAvailability::

+ ENABLED_FOR_OFFLINER) > 0));

} else {

ResolveJavascriptCallback(*callback_id, base::FundamentalValue(false));

}