Chromium Code Reviews| Index: ui/display/fake_display_delegate.h |
| diff --git a/ui/display/fake_display_delegate.h b/ui/display/fake_display_delegate.h |
| index d6d05ed8055937e919a60eb6430fe661a79ca58a..d6942c34c2a9c218430435bcd1011c42f79f86ee 100644 |
| --- a/ui/display/fake_display_delegate.h |
| +++ b/ui/display/fake_display_delegate.h |
| @@ -27,15 +27,23 @@ namespace display { |
| // |
| // The size and number of displays can controlled via --screen-config=X |
| // command line flag with the format: |
| -// HxW[^dpi][,] |
| +// HxW[%R][#HxW[%R][:HxW[%R]]][^D][/[a][c][i][o]][,...] |
|
Daniel Erat
2016/10/05 21:09:45
can you document what the #- and :-prefixed dimens
kylechar
2016/10/07 16:14:42
Improved this comment a bunch I hope.
|
| // H: display height in pixels [int] |
| // W: display width in pixels [int] |
| -// dpi: display physical size set based on DPI [int] |
| +// R: display refresh rate [float] |
| +// D: display DPI, used to set physical size [int] |
| +// Options: |
| +// a: display is aspect preserving |
| +// c: display has color correction matrix |
| +// i: display is internal |
| +// o: display has overscan |
| // |
| -// Two 800x800 displays: |
| -// --screen-config=800x800,800x800 |
| -// One 1820x1080 display and one 400x400 display: |
| -// --screen-config=1920x1080,400x400 |
| +// Two 800x800 displays, with first display as internal display: |
| +// --screen-config=800x800/i,800x800 |
| +// One 1920x1080 display as internal display with alternate resolutions: |
| +// --screen-config=1920x1080#1600x900:1280x720/i |
| +// One 1600x900 display with 120 refresh rate and high-DPI: |
| +// --screen-config=1600x900%120^300 |
| // No displays: |
| // --screen-config=none |
| // |
| @@ -89,11 +97,6 @@ class DISPLAY_EXPORT FakeDisplayDelegate : public ui::NativeDisplayDelegate, |
| FakeDisplayController* GetFakeDisplayController() override; |
| protected: |
| - // Creates a display snapshot from the provided |spec| string. Return null if |
| - // |spec| is invalid. |
| - std::unique_ptr<ui::DisplaySnapshot> CreateSnapshotFromSpec( |
| - const std::string& spec); |
| - |
| // Sets initial display snapshots from command line flag. Returns true if |
| // command line flag was provided. |
| bool InitFromCommandLine(); |