Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2395863004: Don't run CaptureScreenshotTest#CaptureScreenshot on low-end devices (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
Reviewers:
dgozman, Eric Seckler
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't run CaptureScreenshotTest#CaptureScreenshot on low-end devices This test fails consistently on low-end Android devices. Return early instead of running the test. BUG=653637 TBR=eseckler@chromium.org, dgozman@chromium.org Committed: https://crrev.com/a4940d397e4fe8152db1430920eef08f907a98de Cr-Commit-Position: refs/heads/master@{#423704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395863004/1
4 years, 2 months ago (2016-10-06 21:51:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 21:57:22 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4940d397e4fe8152db1430920eef08f907a98de Cr-Commit-Position: refs/heads/master@{#423704}
4 years, 2 months ago (2016-10-06 21:59:22 UTC) #9
Eric Seckler
4 years, 2 months ago (2016-10-07 08:31:50 UTC) #10
Message was sent while issue was closed.
lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698