Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2325)

Unified Diff: device/generic_sensor/platform_sensor_provider_android.cc

Issue 2395853003: [Sensors] Improvements in shared buffer managing (Closed)
Patch Set: Test compilation fix + comment from Ken Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/generic_sensor/platform_sensor_provider_android.cc
diff --git a/device/generic_sensor/platform_sensor_provider_android.cc b/device/generic_sensor/platform_sensor_provider_android.cc
index 19c700c338f990f86717eb0f14666a759aad68a8..2506dba4f48016f88ccc51a347a51b55f5b8f6ba 100644
--- a/device/generic_sensor/platform_sensor_provider_android.cc
+++ b/device/generic_sensor/platform_sensor_provider_android.cc
@@ -25,7 +25,6 @@ class PlatformSensorProviderAndroid : public PlatformSensorProvider {
protected:
void CreateSensorInternal(mojom::SensorType type,
mojo::ScopedSharedBufferMapping mapping,
- uint64_t buffer_size,
const CreateSensorCallback& callback) override;
private:
@@ -58,7 +57,6 @@ PlatformSensorProviderAndroid::~PlatformSensorProviderAndroid() = default;
void PlatformSensorProviderAndroid::CreateSensorInternal(
mojom::SensorType type,
mojo::ScopedSharedBufferMapping mapping,
- uint64_t buffer_size,
const CreateSensorCallback& callback) {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> sensor = Java_PlatformSensorProvider_createSensor(
@@ -68,8 +66,7 @@ void PlatformSensorProviderAndroid::CreateSensorInternal(
callback.Run(nullptr);
scoped_refptr<PlatformSensorAndroid> concrete_sensor =
- new PlatformSensorAndroid(type, std::move(mapping), buffer_size, this,
- sensor);
+ new PlatformSensorAndroid(type, std::move(mapping), this, sensor);
callback.Run(concrete_sensor);
}
« no previous file with comments | « device/generic_sensor/platform_sensor_android.cc ('k') | device/generic_sensor/platform_sensor_provider_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698