Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: device/generic_sensor/platform_sensor_android.h

Issue 2395853003: [Sensors] Improvements in shared buffer managing (Closed)
Patch Set: Pass task runner to PlatformSensor constructor Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/generic_sensor/platform_sensor_android.h
diff --git a/device/generic_sensor/platform_sensor_android.h b/device/generic_sensor/platform_sensor_android.h
index caebc45709205ea1f6e098922d7a432dbf02a417..279bd3456f2682a24682a8b845c4125707e76cc1 100644
--- a/device/generic_sensor/platform_sensor_android.h
+++ b/device/generic_sensor/platform_sensor_android.h
@@ -22,19 +22,24 @@ class PlatformSensorAndroid : public PlatformSensor {
PlatformSensorAndroid(mojom::SensorType type,
mojo::ScopedSharedBufferMapping mapping,
- uint64_t buffer_size,
PlatformSensorProvider* provider,
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner,
const base::android::JavaRef<jobject>& java_sensor);
mojom::ReportingMode GetReportingMode() override;
PlatformSensorConfiguration GetDefaultConfiguration() override;
- void NotifyPlatformSensorReadingChanged(
- JNIEnv*,
- const base::android::JavaRef<jobject>& caller);
void NotifyPlatformSensorError(JNIEnv*,
const base::android::JavaRef<jobject>& caller);
+ void UpdatePlatformSensorReading(
+ JNIEnv*,
+ const base::android::JavaRef<jobject>& caller,
+ jdouble timestamp,
+ jdouble value1,
+ jdouble value2,
+ jdouble value3);
+
protected:
~PlatformSensorAndroid() override;
bool StartSensor(const PlatformSensorConfiguration& configuration) override;
@@ -45,10 +50,6 @@ class PlatformSensorAndroid : public PlatformSensor {
private:
// Java object org.chromium.device.sensors.PlatformSensor
base::android::ScopedJavaGlobalRef<jobject> j_object_;
- // Task runner that is used by mojo objects for the IPC. Android sensor
- // objects share separate handler thread that processes sensor
- // events. Notifications from Java side are forwarded to |task_runner_|.
- scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
DISALLOW_COPY_AND_ASSIGN(PlatformSensorAndroid);
};

Powered by Google App Engine
This is Rietveld 408576698