Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2395843003: views: fix MdTextButton stroke alpha (Closed)

Created:
4 years, 2 months ago by Elly Fong-Jones
Modified:
4 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: fix MdTextButton stroke alpha 1) Prominent buttons should have no stroke, so use alpha = 0.0 for them 2) Non-prominent button stroke changed to alpha = 0.2 BUG=652462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/views/controls/button/md_text_button.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Elly Fong-Jones
estade: ptal? :)
4 years, 2 months ago (2016-10-06 14:42:50 UTC) #3
Evan Stade
Thanks for this patch, but this overlaps with [1]. (As far as the differences between ...
4 years, 2 months ago (2016-10-06 16:49:16 UTC) #4
Elly Fong-Jones
On 2016/10/06 16:49:16, Evan Stade wrote: > Thanks for this patch, but this overlaps with ...
4 years, 2 months ago (2016-10-06 16:50:24 UTC) #5
Evan Stade
4 years, 2 months ago (2016-10-06 16:53:52 UTC) #6
Message was sent while issue was closed.
On 2016/10/06 16:50:24, Elly Fong-Jones wrote:
> On 2016/10/06 16:49:16, Evan Stade wrote:
> > Thanks for this patch, but this overlaps with [1]. (As far as the
differences
> > between this and [1] go, I don't think we need to double the opacity for the
> > themed button case any more now that we have a higher opacity to begin
with.)
> > 
> > [1] https://codereview.chromium.org/2400563004/
> 
> Ah, cool, I didn't realize that CL existed. I'll close this one :)

I should have cc'd you.

Powered by Google App Engine
This is Rietveld 408576698