Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2395803003: [Extensions] Add metrics for execution time of binding.js (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
Reviewers:
Mark P, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add metrics for execution time of binding.js Add UMA for the time it takes for the BindingGeneratingNativeHandler to create the JS object representing an API object. Since this tends to be a fast process (but a repeated one), use microsecond accuracy. BUG=608561 Committed: https://crrev.com/c6be58d620359b6c02b4b8b60a554dff2a928e6e Cr-Commit-Position: refs/heads/master@{#423384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M extensions/renderer/binding_generating_native_handler.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
Mark and lazyboy@, mind taking a look?
4 years, 2 months ago (2016-10-05 21:24:02 UTC) #2
Mark P
lgtm
4 years, 2 months ago (2016-10-05 23:02:45 UTC) #3
lazyboy
lgtm.
4 years, 2 months ago (2016-10-05 23:33:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395803003/1
4 years, 2 months ago (2016-10-06 00:17:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 01:36:19 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 01:38:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6be58d620359b6c02b4b8b60a554dff2a928e6e
Cr-Commit-Position: refs/heads/master@{#423384}

Powered by Google App Engine
This is Rietveld 408576698