Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2395803002: Remove FX_BOOL from core/fpdfapi/font (Closed)

Created:
4 years, 2 months ago by npm
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FX_BOOL from core/fpdfapi/font FX_BOOL can be replaced by bool. Also replaced in a couple other places so that Winbots pass. Committed: https://pdfium.googlesource.com/pdfium/+/7c1b07fde27dfbbf1d979d9dfd616b1a42591e5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M core/fpdfapi/font/cpdf_font.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M core/fpdfapi/font/cpdf_fontencoding.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/font/cpdf_fontencoding.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/font/cpdf_truetypefont.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/font/cpdf_type1font.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M core/fpdfapi/font/cpdf_type3char.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/font/cpdf_type3char.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfapi/font/ttgsubtable.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/font/ttgsubtable.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfapi/page/fpdf_page_parser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/page/pageint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
npm
PTAL
4 years, 2 months ago (2016-10-05 14:27:00 UTC) #5
dsinclair
lgtm
4 years, 2 months ago (2016-10-05 14:28:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395803002/1
4 years, 2 months ago (2016-10-05 15:07:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 15:07:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7c1b07fde27dfbbf1d979d9dfd616b1a4259...

Powered by Google App Engine
This is Rietveld 408576698