ui/views/corewm/tooltip_controller.cc - Issue 23958012: Create the Tooltip widget in Aura as needed instead of just creating it in the timer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/corewm/tooltip_controller.cc

Issue 23958012: Create the Tooltip widget in Aura as needed instead of just creating it in the timer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/corewm/tooltip_controller.cc

===================================================================

--- ui/views/corewm/tooltip_controller.cc (revision 223170)

+++ ui/views/corewm/tooltip_controller.cc (working copy)

@@ -278,8 +278,13 @@

if (tooltip_window_)

tooltip_window_->RemoveObserver(this);

tooltip_window_ = target;

- if (tooltip_window_)

+ if (tooltip_window_) {

tooltip_window_->AddObserver(this);

+ } else {

+ // If the tooltip_window_ is reparented then we need to recreate the

+ // tooltip to ensure that it shows up correctly.

+ tooltip_.reset(NULL);

+ }

}

curr_mouse_loc_ = event->location();

if (tooltip_timer_.IsRunning())

« no previous file with comments | « no previous file | no next file » | no next file with comments »