Create the Tooltip widget in Aura as needed instead of just creating it in the timer.

ui/views/corewm/tooltip_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/corewm/tooltip_controller.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/location.h"
@@ skipping 69 matching lines @@
 }
 
 }  // namespace
 
 namespace views {
 namespace corewm {
 
 // Displays a widget with tooltip using a views::Label.
 class TooltipController::Tooltip : public views::WidgetObserver {
  public:
+  friend class TooltipController;
+
   Tooltip(TooltipController* controller)
       : controller_(controller),
         widget_(NULL) {
     label_.set_background(
         views::Background::CreateSolidBackground(kTooltipBackground));
     if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kNoDropShadows)) {
       label_.set_border(
           views::Border::CreateSolidBorder(kTooltipBorderWidth,
                                            kTooltipBorder));
     }
@@ skipping 16 matching lines @@
         &line_count);
     label_.SetText(trimmed_text);
 
     int width = max_width + 2 * kTooltipHorizontalPadding;
     int height = label_.GetHeightForWidth(max_width) +
         2 * kTooltipVerticalPadding;
     if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kNoDropShadows)) {
       width += 2 * kTooltipBorderWidth;
       height += 2 * kTooltipBorderWidth;
     }
-    GetWidgetForWindow(window);
     SetTooltipBounds(location, width, height);

[sky, 2013/09/16 22:46:51]

Won't this mean we potentially set the bounds only to recreate later on? And
similarly if you invoke GetWidgetForWindow later on and recreate the widget
won't the bounds be wrong?

[ananta, 2013/09/16 23:45:46]

As per our discussion, we now destroy the tooltip if the tooltip_window_ is
NULLed out.

   }
 
   // Shows the tooltip.
   void Show() {
     if (widget_)
       widget_->Show();
   }
 
   // Hides the tooltip.
   void Hide() {
@@ skipping 383 matching lines @@
   if (!tooltip_window_)
     return false;
   aura::client::DragDropClient* client =
       aura::client::GetDragDropClient(tooltip_window_->GetRootWindow());
   return client && client->IsDragDropInProgress();
 }
 
 TooltipController::Tooltip* TooltipController::GetTooltip() {
   if (!tooltip_.get())
     tooltip_.reset(new Tooltip(this));
+  if (tooltip_window_)
+    tooltip_->GetWidgetForWindow(tooltip_window_);

[sky, 2013/09/16 22:46:51]

I know we discussed invoking GetWidgetForWindow, but now that I see it this
isn't the right place. Or rather TooltipWindow should expose a better API for
this.

[ananta, 2013/09/16 23:45:46]

This is no longer needed.

   return tooltip_.get();
 }
 
 bool TooltipController::IsCursorVisible() {
   if (!tooltip_window_)
     return false;
   aura::RootWindow* root = tooltip_window_->GetRootWindow();
   if (!root)
     return false;
   aura::client::CursorClient* cursor_client =
       aura::client::GetCursorClient(root);
   // |cursor_client| may be NULL in tests, treat NULL as always visible.
   return !cursor_client || cursor_client->IsCursorVisible();
 }
 
 int TooltipController::GetTooltipShownTimeout() {
   std::map<aura::Window*, int>::const_iterator it =
       tooltip_shown_timeout_map_.find(tooltip_window_);
   if (it == tooltip_shown_timeout_map_.end())
     return kDefaultTooltipShownTimeoutMs;
   return it->second;
 }
 
 }  // namespace corewm
 }  // namespace views