Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2395793004: Move isTargetAttributeCSSProperty to SVGAnimateElement (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move isTargetAttributeCSSProperty to SVGAnimateElement SVGAnimateElement is the only user. Move it and make it a free function. BUG=641437 Committed: https://crrev.com/079821affa2e8e946e45f607c4cbc26458cacd68 Cr-Commit-Position: refs/heads/master@{#423817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 4 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 2 months ago (2016-10-06 22:01:23 UTC) #4
pdr.
On 2016/10/06 at 22:01:23, fs wrote: > LGTM
4 years, 2 months ago (2016-10-06 22:03:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395793004/1
4 years, 2 months ago (2016-10-07 07:54:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 07:59:56 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 08:02:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/079821affa2e8e946e45f607c4cbc26458cacd68
Cr-Commit-Position: refs/heads/master@{#423817}

Powered by Google App Engine
This is Rietveld 408576698