Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2395783002: Revert of [turbofan] Osr value typing + dynamic type checks on entry. (Closed)

Created:
4 years, 2 months ago by Jarin
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy, Michael Starzinger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Osr value typing + dynamic type checks on entry. (patchset #5 id:80001 of https://codereview.chromium.org/2384113002/ ) Reason for revert: Tanks the world. Original issue's description: > [turbofan] Osr value typing + dynamic type checks on entry. > > This introduces a new OsrGuard node that is inserted during graph building > to guard the inferred type of the OSR value. > > The type of the OSR value is inferred by running the typer before OSR > deconstruction, and then taking the type from the phi that takes the > OSR value. After the deconstruction, we throw the types away. > > At the moment we only support the SignedSmall OSR type and we always > pick the tagged representation. Later, we might want to support more > types (such as Number) and pick better representations (int32/float64). > > This CL also removes the OSR deconstruction tests because they build > unrealistic graph (no effect chain, no loop termination). I considered > adding the effect chains to the tests, but this would make the tests > even more brittle. > > Committed: https://crrev.com/1f5dc90a900d222da44bee3eff171a2ba1e3c076 > Cr-Commit-Position: refs/heads/master@{#39971} TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ff81734cb95233939e8528a4c3a4894b86e0a348 Cr-Commit-Position: refs/heads/master@{#39985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -352 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +12 lines, -34 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/compiler/common-operator.cc View 3 chunks +1 line, -32 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-frame-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node-properties.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/osr.cc View 4 chunks +5 lines, -48 lines 0 comments Download
M src/compiler/pipeline.cc View 4 chunks +3 lines, -29 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +2 lines, -30 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/compiler/test-osr.cc View 1 chunk +575 lines, -0 lines 0 comments Download
D test/mjsunit/compiler/osr-typing-debug-change.js View 1 chunk +0 lines, -119 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jarin
Created Revert of [turbofan] Osr value typing + dynamic type checks on entry.
4 years, 2 months ago (2016-10-05 10:34:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395783002/1
4 years, 2 months ago (2016-10-05 10:34:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 10:34:28 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 10:34:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff81734cb95233939e8528a4c3a4894b86e0a348
Cr-Commit-Position: refs/heads/master@{#39985}

Powered by Google App Engine
This is Rietveld 408576698