Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2395763004: Disable MessageLoop features on some BrowserThreads. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable MessageLoop features on some BrowserThreads. base/task_scheduler doesn't support nested loops, destruction observers or task observers. This CL disables these features on some browser threads in preparation for their migration to base/task_scheduler. BUG=653916

Patch Set 1 #

Patch Set 2 : do not run destruction observers #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M base/message_loop/message_loop.h View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 2 3 4 chunks +11 lines, -2 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2402553005 Patch 40001

Messages

Total messages: 17 (17 generated)
fdoray
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-06 18:25:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395763004/1
4 years, 2 months ago (2016-10-06 18:26:11 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-06 19:16:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/237464)
4 years, 2 months ago (2016-10-06 19:16:35 UTC) #4
fdoray
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-06 19:43:58 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395763004/20001
4 years, 2 months ago (2016-10-06 19:44:30 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-06 20:40:13 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/310140)
4 years, 2 months ago (2016-10-06 20:40:14 UTC) #8
fdoray
Description was changed from ========== Disable MessageLoop features on some BrowserThreads. BUG= ========== to ========== ...
4 years, 2 months ago (2016-10-07 17:26:05 UTC) #9
fdoray
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-07 17:26:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395763004/40001
4 years, 2 months ago (2016-10-07 17:26:34 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-07 18:32:30 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/312296) mac_chromium_rel_ng on ...
4 years, 2 months ago (2016-10-07 18:32:31 UTC) #13
fdoray
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-11 12:56:24 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395763004/60001
4 years, 2 months ago (2016-10-11 12:56:36 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-11 14:21:01 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 14:21:01 UTC) #17 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698