Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2395763003: Do not white list offline archive directory (Closed)

Created:
4 years, 2 months ago by jianli
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not white list offline archive directory This is not longer needed after we switch to using offline interceptor BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ca52e6c7bc29818fad9f2422d54530a699a63188 Cr-Commit-Position: refs/heads/master@{#423741}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unneeded include file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/net/chrome_network_delegate.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/offline_pages/offline_internals.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
jianli
mmenke for chrome_network_delegate.cc dbeam for offline_internals.js
4 years, 2 months ago (2016-10-06 00:46:01 UTC) #5
Dan Beam
lgtm
4 years, 2 months ago (2016-10-06 00:48:35 UTC) #6
mmenke
LGTM, thanks for removing this! https://codereview.chromium.org/2395763003/diff/1/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (left): https://codereview.chromium.org/2395763003/diff/1/chrome/browser/net/chrome_network_delegate.cc#oldcode522 chrome/browser/net/chrome_network_delegate.cc:522: profile_path_.Append(chrome::kOfflinePageArchivesDirname); Do we still ...
4 years, 2 months ago (2016-10-06 15:28:31 UTC) #9
jianli
https://codereview.chromium.org/2395763003/diff/1/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (left): https://codereview.chromium.org/2395763003/diff/1/chrome/browser/net/chrome_network_delegate.cc#oldcode522 chrome/browser/net/chrome_network_delegate.cc:522: profile_path_.Append(chrome::kOfflinePageArchivesDirname); On 2016/10/06 15:28:31, mmenke wrote: > Do we ...
4 years, 2 months ago (2016-10-06 22:31:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395763003/20001
4 years, 2 months ago (2016-10-06 22:32:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 23:43:15 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:45:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca52e6c7bc29818fad9f2422d54530a699a63188
Cr-Commit-Position: refs/heads/master@{#423741}

Powered by Google App Engine
This is Rietveld 408576698