[inspector] Turn on inspector by default

[inspector] Turn on inspector by default

BUG=chromium:635948
Committed: https://crrev.com/8146402c69044affff0e95f9641eee532fb70312
Cr-Commit-Position: refs/heads/master@{#40380}

[Michael Achenbach, 2016-10-05 08:49:24]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 08:49:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 08:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 08:57:06]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Michael Achenbach, 2016-10-05 08:58:58]

Description was changed from

==========
[inspector] Turn on inspector by default

BUG=
==========

to

==========
[inspector] Turn on inspector by default

BUG=chromium:635948
==========

[Michael Achenbach, 2016-10-05 19:50:08]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:50:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 20:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:19:43]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-10-11 18:20:33]

machenbach@chromium.org changed reviewers:
+ dgozman@chromium.org, kozyatinskiy@chromium.org, yangguo@chromium.org

[Michael Achenbach, 2016-10-11 18:20:34]

PTAL. Guess we're ready to land this and the successor. We'd have the inspector
on on most bots, except the gyp bot in the CQ, the noi18n bot and other CI gyp
bots that target node.js platforms.

[kozy, 2016-10-11 18:22:03]

lgtm

[dgozman, 2016-10-11 19:36:49]

Sounds good, but let's wait a bit more until we merge the current state to
Node.js to be sure everything works. I don't think we have to rush this.

[Michael Achenbach, 2016-10-11 20:56:00]

On 2016/10/11 19:36:49, dgozman wrote:
> Sounds good, but let's wait a bit more until we merge the current state to
> Node.js to be sure everything works. I don't think we have to rush this.

Fine, I keep this on ice until you give green light. I could land the follow up
patch independently. It adds swarming support. We can add it without actually
turning the inspector on anywhere.

[dgozman, 2016-10-17 19:07:21]

lgtm

[jochen (gone - plz use gerrit), 2016-10-18 04:14:59]

On 2016/10/17 at 19:07:21, dgozman wrote:
> lgtm

node doesn't use gn yet anyway, so lgtm

[Yang, 2016-10-18 05:04:20]

On 2016/10/18 04:14:59, jochen wrote:
> On 2016/10/17 at 19:07:21, dgozman wrote:
> > lgtm
> 
> node doesn't use gn yet anyway, so lgtm

lgtm.

[Michael Achenbach, 2016-10-18 06:16:03]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 06:16:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 06:40:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 06:40:56]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-10-18 06:41:55]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-10-18 06:42:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 06:44:23]

Description was changed from

==========
[inspector] Turn on inspector by default

BUG=chromium:635948
==========

to

==========
[inspector] Turn on inspector by default

BUG=chromium:635948
==========

[commit-bot: I haz the power, 2016-10-18 06:44:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-18 06:45:06]

Description was changed from

==========
[inspector] Turn on inspector by default

BUG=chromium:635948
==========

to

==========
[inspector] Turn on inspector by default

BUG=chromium:635948

Committed: https://crrev.com/8146402c69044affff0e95f9641eee532fb70312
Cr-Commit-Position: refs/heads/master@{#40380}
==========

[commit-bot: I haz the power, 2016-10-18 06:45:08]

Patchset 1 (id:??) landed as
https://crrev.com/8146402c69044affff0e95f9641eee532fb70312
Cr-Commit-Position: refs/heads/master@{#40380}

[Michael Achenbach, 2016-10-18 14:06:12]

This had no effect. Actually running the inspector tests is now blocked on a fix
like this:
https://codereview.chromium.org/2431653002/

[Michael Achenbach, 2016-10-19 07:03:48]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2430223003/ by machenbach@chromium.org.

The reason for reverting is: Has test failures on windows and blocks landing a
test driver fix..

[Michael Achenbach, 2016-10-19 11:16:38]

Description was changed from

==========
[inspector] Turn on inspector by default

BUG=chromium:635948

Committed: https://crrev.com/8146402c69044affff0e95f9641eee532fb70312
Cr-Commit-Position: refs/heads/master@{#40380}
==========

to

==========
[inspector] Turn on inspector by default

BUG=chromium:635948

Committed: https://crrev.com/8146402c69044affff0e95f9641eee532fb70312
Cr-Commit-Position: refs/heads/master@{#40380}
==========

[Michael Achenbach, 2016-10-19 11:16:54]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 11:17:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-10-19 11:17:22]

Will reland this, once all inspector bugs are fixed.

[commit-bot: I haz the power, 2016-10-19 11:37:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 11:37:34]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/16392)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/16471)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Michael Achenbach, 2016-10-21 07:51:15]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 07:51:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 08:14:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 08:14:53]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/16618)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Michael Achenbach, 2016-10-25 07:23:51]

Abandoning this CL as this one has landed:
https://codereview.chromium.org/2450653002/