[NTP Snippets] Hook up background fetching scheduler to UserClassifier

[NTP Snippets] Hook up background fetching scheduler to UserClassifier

BUG=646842
Committed: https://crrev.com/0ef69737d8d9cb0bfe54ce36b50174851e2d2b90
Cr-Commit-Position: refs/heads/master@{#423130}

[Marc Treib, 2016-10-05 09:22:49]

treib@chromium.org changed reviewers:
+ jkrcal@chromium.org

[Marc Treib, 2016-10-05 09:22:50]

PTAL!

https://codereview.chromium.org/2395753003/diff/1/components/ntp_snippets/swi...
File components/ntp_snippets/switches.h (left):

https://codereview.chromium.org/2395753003/diff/1/components/ntp_snippets/swi...
components/ntp_snippets/switches.h:13: extern const char
kFetchingIntervalFallbackSeconds[];
No need for explicit switches, since you can also override variation params via
the command line if you really want that.

[jkrcal, 2016-10-05 10:48:58]

lgtm, thanks!

https://codereview.chromium.org/2395753003/diff/1/components/ntp_snippets/swi...
File components/ntp_snippets/switches.h (left):

https://codereview.chromium.org/2395753003/diff/1/components/ntp_snippets/swi...
components/ntp_snippets/switches.h:13: extern const char
kFetchingIntervalFallbackSeconds[];
On 2016/10/05 09:22:50, Marc Treib wrote:
> No need for explicit switches, since you can also override variation params
via
> the command line if you really want that.

Acknowledged.

[Marc Treib, 2016-10-05 11:01:37]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[Marc Treib, 2016-10-05 11:01:59]

treib@chromium.org changed reviewers:
+ noyau@chromium.org

[Marc Treib, 2016-10-05 11:01:59]

+noyau for ios/, PTAL!

[commit-bot: I haz the power, 2016-10-05 11:02:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-10-05 11:11:17]

On 2016/10/05 11:01:59, Marc Treib wrote:
> +noyau for ios/, PTAL!

noyau is OOO today, lgtm as ios/ OWNERS.

[Marc Treib, 2016-10-05 11:13:29]

On 2016/10/05 11:11:17, sdefresne wrote:
> On 2016/10/05 11:01:59, Marc Treib wrote:
> > +noyau for ios/, PTAL!
> 
> noyau is OOO today, lgtm as ios/ OWNERS.

Thanks for jumping in! Awesome!

[commit-bot: I haz the power, 2016-10-05 11:36:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 11:36:19]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-10-05 11:45:33]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-10-05 11:45:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 11:50:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-05 11:51:59]

Description was changed from

==========
[NTP Snippets] Hook up background fetching scheduler to UserClassifier

BUG=646842
==========

to

==========
[NTP Snippets] Hook up background fetching scheduler to UserClassifier

BUG=646842

Committed: https://crrev.com/0ef69737d8d9cb0bfe54ce36b50174851e2d2b90
Cr-Commit-Position: refs/heads/master@{#423130}
==========

[commit-bot: I haz the power, 2016-10-05 11:52:00]

Patchset 1 (id:??) landed as
https://crrev.com/0ef69737d8d9cb0bfe54ce36b50174851e2d2b90
Cr-Commit-Position: refs/heads/master@{#423130}