Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2395743004: Revert of [interpreter] Add string type feedback to add (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Add string type feedback to add (patchset #3 id:40001 of https://codereview.chromium.org/2392533002/ ) Reason for revert: Fails unittests on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/5026 Original issue's description: > [interpreter] Add string type feedback to add > > Adds string type feedback to Ignition's AddWithFeedback code stub, for now only > adding a special case for when both lhs and rhs are strings. This improves > octane's splay by >100%. > > BUG=v8:5400 > > Committed: https://crrev.com/fb4ae2239d37adaf0321165034050316914de708 > Cr-Commit-Position: refs/heads/master@{#39987} TBR=rmcilroy@chromium.org,mythria@chromium.org,leszeks@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5400 Committed: https://crrev.com/22a62df3449758c833769ebe2fbeb1bf51387d52 Cr-Commit-Position: refs/heads/master@{#39991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -69 lines) Patch
M src/code-stubs.cc View 5 chunks +7 lines, -34 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 6 chunks +12 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [interpreter] Add string type feedback to add
4 years, 2 months ago (2016-10-05 13:04:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395743004/1
4 years, 2 months ago (2016-10-05 13:04:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 13:04:47 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:05:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22a62df3449758c833769ebe2fbeb1bf51387d52
Cr-Commit-Position: refs/heads/master@{#39991}

Powered by Google App Engine
This is Rietveld 408576698