Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2395743003: [wasm] Move test-signatures.h from test/cctest to test/common (Closed)

Created:
4 years, 2 months ago by ahaas
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move test-signatures.h from test/cctest to test/common R=titzer@chromium.org Committed: https://crrev.com/90080f2a6b7f30afc16113c9c5e81e64c1153b9a Cr-Commit-Position: refs/heads/master@{#39988}

Patch Set 1 #

Patch Set 2 : Delete old build file entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -145 lines) Patch
M BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-asmjs.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download
D test/cctest/wasm/test-signatures.h View 1 chunk +0 lines, -132 lines 0 comments Download
M test/cctest/wasm/test-wasm-stack.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-wasm-trap-position.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/common/wasm/test-signatures.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/fuzzer/fuzzer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/fuzzer/wasm-code.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/loop-assignment-analysis-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/wasm-module-builder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
ahaas
4 years, 2 months ago (2016-10-05 10:49:37 UTC) #1
titzer
On 2016/10/05 10:49:37, ahaas wrote: lgtm
4 years, 2 months ago (2016-10-05 10:51:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395743003/20001
4 years, 2 months ago (2016-10-05 11:56:54 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 11:59:54 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 12:00:07 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90080f2a6b7f30afc16113c9c5e81e64c1153b9a
Cr-Commit-Position: refs/heads/master@{#39988}

Powered by Google App Engine
This is Rietveld 408576698