Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2395743002: GN: Add default target (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 2 months ago
Reviewers:
fbarchard, fbarchard1
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

GN: Add default target This reduces the number of objects when not specifying a build target during compile. This is especially significant for Android where the number of objects decreases from 3322 to 1761. BUG=libyuv:644 R=fbarchard@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/1cd384140daa0f30a3df5170903018a761028397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_chromium
4 years, 2 months ago (2016-10-05 07:47:30 UTC) #3
fbarchard1
lgtm
4 years, 2 months ago (2016-10-05 18:15:19 UTC) #5
fbarchard1
Committed patchset #1 (id:1) manually as 1cd384140daa0f30a3df5170903018a761028397 (presubmit successful).
4 years, 2 months ago (2016-10-05 18:17:32 UTC) #7
fbarchard1
4 years, 2 months ago (2016-10-05 18:44:52 UTC) #8
Message was sent while issue was closed.
gn gen out/Release "--args=is_debug=false target_os=\"android\"
target_cpu=\"arm64\""
time ninja -j7 -v -C out/Release

Was
real	4m21.449s
Done. Made 827 targets from 101 files in 527ms
3290 objects

Now
real	2m16.326s
Done. Made 828 targets from 101 files in 559ms
1729 objects

Powered by Google App Engine
This is Rietveld 408576698