Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2395703003: Set string-prototype-properties to NeedsRebaseline (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set string-prototype-properties to NeedsRebaseline The expectations incorrectly expect 'subString' instead of 'substring' in the case when substring is called on null or undefined. BUG=chromium:650247 Committed: https://crrev.com/1ac115153c05b826281bab0dd808b251634c7d55 Cr-Commit-Position: refs/heads/master@{#423132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
This has now been fixed in V8.
4 years, 2 months ago (2016-10-05 07:48:10 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-05 11:53:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395703003/1
4 years, 2 months ago (2016-10-05 11:57:04 UTC) #9
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-10-05 12:02:48 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 12:04:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ac115153c05b826281bab0dd808b251634c7d55
Cr-Commit-Position: refs/heads/master@{#423132}

Powered by Google App Engine
This is Rietveld 408576698