tools/perf/page_sets/key_mobile_sites.json - Issue 23957002: Telemetry: Fix facebook.com on key_mobile_sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_mobile_sites.json

Issue 23957002: Telemetry: Fix facebook.com on key_mobile_sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/key_mobile_sites.json

diff --git a/tools/perf/page_sets/key_mobile_sites.json b/tools/perf/page_sets/key_mobile_sites.json

index dec87c8d345a32bf8d940b165725c0fc7c72a28d..7ef5af4289924144ca4b4bccd5901690ae2bda61 100644

--- a/tools/perf/page_sets/key_mobile_sites.json

+++ b/tools/perf/page_sets/key_mobile_sites.json

@@ -70,7 +70,7 @@

"why": "#1 (Alexa global)",

"navigate_steps": [

{ "action": "navigate" },

- { "action": "wait", "javascript": "document.getElementById('u_0_c') !== null" }

+ { "action": "wait", "javascript": "document.getElementById('u_0_c') !== null && document.body.scrollHeight > window.innerHeight" }

tonyg 2013/09/04 17:27:19 Does this work for all screen sizes? I'm worried t

Dominik Grewe 2013/09/04 20:05:52 It should work if there's anything to scroll :) An

tonyg 2013/09/04 20:29:43 You are right. The test will fail anyway if there

]

{

« no previous file with comments | « no previous file | no next file » | no next file with comments »