Allow linux installer to be build without chrome branding

Allow linux installer to be build without chrome branding

This change allows chromium developers to build
installer packages by setting 'is_official_build'
without requiring 'is_chrome_branded'.

This allows the installer scripts to be developed
and tested without needing access to the closed source
chrome branding.

BUG=564904
Committed: https://crrev.com/fa8f43b2fd4d831b1422b1ad3d10c54da941752a
Cr-Commit-Position: refs/heads/master@{#423197}

[Sam Clegg, 2016-10-05 00:21:05]

sbc@chromium.org changed reviewers:
+ thestig@chromium.org

[Sam Clegg, 2016-10-05 00:21:05]

I found this useful to be able to build packages with
only the open source repo.  What do you think?

[Lei Zhang, 2016-10-05 01:14:49]

https://groups.google.com/a/chromium.org/d/topic/chromium-dev/4F5hM8XMOhQ/dis...
says "is_official_build" really means "build with optimization" so it doesn't
sound like the right flag to gate this on.

[Lei Zhang, 2016-10-05 01:16:14]

What if we just dropped the is_official_build checks from patch set 1? Would
that break some build bots?

[Sam Clegg, 2016-10-05 01:19:50]

On 2016/10/05 01:16:14, Lei Zhang wrote:
> What if we just dropped the is_official_build checks from patch set 1? Would
> that break some build bots?

I would have though it would be nice for the installer targets to not show up in
most developers 'all' target.   (Do people often build 'all'?). 

Would one ever what to package something that wasn't built with
is_official_build?

[Lei Zhang, 2016-10-05 01:24:28]

On 2016/10/05 01:19:50, Sam Clegg wrote:
> On 2016/10/05 01:16:14, Lei Zhang wrote:
> > What if we just dropped the is_official_build checks from patch set 1? Would
> > that break some build bots?
> 
> I would have though it would be nice for the installer targets to not show up
in
> most developers 'all' target.   (Do people often build 'all'?). 

I sometimes build with no targets. Is that the same as 'all' ?

Do we want a new GN variable to gate the installer targets? e.g.

enable_linux_installer = is_desktop_linux && is_chrome_branded && target_cpu ==
"x64"

and let people override as needed?

> Would one ever what to package something that wasn't built with
> is_official_build?

Maybe for testing.

[Sam Clegg, 2016-10-05 02:45:21]

On 2016/10/05 01:24:28, Lei Zhang wrote:
> On 2016/10/05 01:19:50, Sam Clegg wrote:
> > On 2016/10/05 01:16:14, Lei Zhang wrote:
> > > What if we just dropped the is_official_build checks from patch set 1?
Would
> > > that break some build bots?
> > 
> > I would have though it would be nice for the installer targets to not show
up
> in
> > most developers 'all' target.   (Do people often build 'all'?). 
> 
> I sometimes build with no targets. Is that the same as 'all' ?
> 
> Do we want a new GN variable to gate the installer targets? e.g.
> 
> enable_linux_installer = is_desktop_linux && is_chrome_branded && target_cpu
==
> "x64"
> 
> and let people override as needed?

Done

> 
> > Would one ever what to package something that wasn't built with
> > is_official_build?
> 
> Maybe for testing.

[Sam Clegg, 2016-10-05 02:45:21]

On 2016/10/05 01:24:28, Lei Zhang wrote:
> On 2016/10/05 01:19:50, Sam Clegg wrote:
> > On 2016/10/05 01:16:14, Lei Zhang wrote:
> > > What if we just dropped the is_official_build checks from patch set 1?
Would
> > > that break some build bots?
> > 
> > I would have though it would be nice for the installer targets to not show
up
> in
> > most developers 'all' target.   (Do people often build 'all'?). 
> 
> I sometimes build with no targets. Is that the same as 'all' ?
> 
> Do we want a new GN variable to gate the installer targets? e.g.
> 
> enable_linux_installer = is_desktop_linux && is_chrome_branded && target_cpu
==
> "x64"
> 
> and let people override as needed?

Done

> 
> > Would one ever what to package something that wasn't built with
> > is_official_build?
> 
> Maybe for testing.

[Lei Zhang, 2016-10-05 05:12:40]

lgtm

[Sam Clegg, 2016-10-05 16:10:18]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2016-10-05 16:10:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 17:11:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 17:13:33]

Description was changed from

==========
Allow linux installer to be build without chrome branding

This change allows chromium developers to build
installer packages by setting 'is_official_build'
without requiring 'is_chrome_branded'.

This allows the installer scripts to be developed
and tested without needing access to the closed source
chrome branding.

BUG=564904
==========

to

==========
Allow linux installer to be build without chrome branding

This change allows chromium developers to build
installer packages by setting 'is_official_build'
without requiring 'is_chrome_branded'.

This allows the installer scripts to be developed
and tested without needing access to the closed source
chrome branding.

BUG=564904

Committed: https://crrev.com/fa8f43b2fd4d831b1422b1ad3d10c54da941752a
Cr-Commit-Position: refs/heads/master@{#423197}
==========

[commit-bot: I haz the power, 2016-10-05 17:13:34]

Patchset 2 (id:??) landed as
https://crrev.com/fa8f43b2fd4d831b1422b1ad3d10c54da941752a
Cr-Commit-Position: refs/heads/master@{#423197}