Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2395653002: Remove buffering from PerformanceLongTaskTiming as it's not in the spec. (Closed)

Created:
4 years, 2 months ago by panicker
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, chasej
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove buffering from PerformanceLongTaskTiming as it's not in the spec. PerformanceLongTaskTiming will only be supported via PerformanceObserver callbacks. BUG=635596 Committed: https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27 Cr-Commit-Position: refs/heads/master@{#423323}

Patch Set 1 #

Patch Set 2 : sync and rebase #

Patch Set 3 : update layout test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -64 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/window-properties-performance-expected.txt View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTypeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/Performance.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 1 7 chunks +5 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp View 1 4 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserver.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
panicker
PTAL
4 years, 2 months ago (2016-10-04 23:15:22 UTC) #3
haraken
LGTM
4 years, 2 months ago (2016-10-05 01:00:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395653002/40001
4 years, 2 months ago (2016-10-05 21:15:43 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 22:48:36 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 22:52:06 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27
Cr-Commit-Position: refs/heads/master@{#423323}

Powered by Google App Engine
This is Rietveld 408576698