src/pathops/SkReduceOrder.cpp - Issue 239563004: fix minor skp-found bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkReduceOrder.cpp

Issue 239563004: fix minor skp-found bugs (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix mac-detected errors Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkReduceOrder.cpp

diff --git a/src/pathops/SkReduceOrder.cpp b/src/pathops/SkReduceOrder.cpp

index ada52761b5c98811b59712df51641bc29ef3aeb5..bb2038b45f2ec864e6c06883c5aabded3ff9fe2d 100644

--- a/src/pathops/SkReduceOrder.cpp

+++ b/src/pathops/SkReduceOrder.cpp

@@ -161,8 +161,8 @@ static int check_linear(const SkDCubic& cubic,

while (cubic[startIndex].approximatelyEqual(cubic[endIndex])) {

--endIndex;

if (endIndex == 0) {

- SkDebugf("%s shouldn't get here if all four points are about equal\n", __FUNCTION__);

- SkASSERT(0);

+ endIndex = 3;

+ break;

}

if (!cubic.isLinear(startIndex, endIndex)) {

« no previous file with comments | « src/pathops/SkPathOpsSimplify.cpp ('k') | tests/PathOpsDebug.cpp » ('j') | no next file with comments »