Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2395613002: Mac: Remove use of deprecated font APIs (Closed)

Created:
4 years, 2 months ago by ccameron
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Mac: Remove use of deprecated font APIs Remove use of CGContextSelectFont CGContextShowTextAtPoint APIs. Verified that the new calls create the same pixel value for the smoothing test as before. Also remove workarounds for 10.6, because it is not supported anymore. BUG=skia:5803 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2395613002 Committed: https://skia.googlesource.com/skia/+/f8ee5b4c6addc9c9670f82718187b19ab2be0798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M src/ports/SkFontHost_mac.cpp View 4 chunks +8 lines, -28 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ccameron
The Mac people are bumping up the SDK version we build against. This was a ...
4 years, 2 months ago (2016-10-04 20:44:27 UTC) #4
bungeman-skia
lgtm
4 years, 2 months ago (2016-10-04 21:32:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395613002/1
4 years, 2 months ago (2016-10-04 21:33:04 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:02:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f8ee5b4c6addc9c9670f82718187b19ab2be0798

Powered by Google App Engine
This is Rietveld 408576698