Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23956010: Define magic descriptors in one place. (Closed)

Created:
7 years, 3 months ago by dshwang
Modified:
7 years, 3 months ago
Reviewers:
agl, jam, Chris Evans
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Define magic descriptors in one place. Currently, zygote and sandbox ipc descriptors are defined in 3 places. This CL defines them in one place. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222594

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M content/browser/child_process_launcher.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/common/zygote_commands_linux.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M content/zygote/zygote_linux.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/zygote/zygote_linux.cc View 1 2 7 chunks +6 lines, -7 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dshwang
7 years, 3 months ago (2013-09-06 11:28:36 UTC) #1
dshwang
7 years, 3 months ago (2013-09-06 17:22:23 UTC) #2
agl
https://codereview.chromium.org/23956010/diff/5001/content/common/zygote_commands_linux.h File content/common/zygote_commands_linux.h (right): https://codereview.chromium.org/23956010/diff/5001/content/common/zygote_commands_linux.h#newcode20 content/common/zygote_commands_linux.h:20: const int kMagicZygoteDescriptor = This renaming seems superfluous. https://codereview.chromium.org/23956010/diff/5001/content/common/zygote_commands_linux.h#newcode22 ...
7 years, 3 months ago (2013-09-09 16:59:07 UTC) #3
dshwang
Thank you for your review. On 2013/09/09 16:59:07, agl wrote: > https://codereview.chromium.org/23956010/diff/5001/content/common/zygote_commands_linux.h > File content/common/zygote_commands_linux.h ...
7 years, 3 months ago (2013-09-09 17:26:25 UTC) #4
agl
lgtm
7 years, 3 months ago (2013-09-10 16:30:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/23956010/12001
7 years, 3 months ago (2013-09-10 16:31:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=24675
7 years, 3 months ago (2013-09-10 16:41:32 UTC) #7
dshwang
On 2013/09/10 16:30:57, agl wrote: > lgtm Thank you for lgtm :) Could other owners ...
7 years, 3 months ago (2013-09-10 16:44:39 UTC) #8
jam
lgtm rubberstamp lgtm
7 years, 3 months ago (2013-09-11 15:30:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/23956010/12001
7 years, 3 months ago (2013-09-11 15:45:44 UTC) #10
commit-bot: I haz the power
Change committed as 222594
7 years, 3 months ago (2013-09-11 18:16:14 UTC) #11
dshwang
7 years, 3 months ago (2013-09-11 18:27:34 UTC) #12
Message was sent while issue was closed. 
On 2013/09/11 15:30:54, jam wrote:
> lgtm
> 
> rubberstamp lgtm

thank you for lgtm :)

Powered by Google App Engine
This is Rietveld 408576698