Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 23956008: [Infobar] Upstream infobar resources. (Closed)

Created:
7 years, 3 months ago by Miguel Garcia
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Infobar] Upstream infobar resources. Separate cl so it can be dcomitted BUG=158817 R=dfalcantara@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A chrome/android/java/res/drawable-hdpi/infobar_button_normal_floating_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/infobar_button_normal_floating_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/infobar_button_warning_floating_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/infobar_button_warning_floating_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/infobar_dismiss.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/warning.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-hdpi/warning.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-xhdpi/warning.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl/warning.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-nodpi/infobar_button_normal_full_left_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-nodpi/infobar_button_normal_full_left_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-nodpi/infobar_button_normal_full_right_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-nodpi/infobar_button_normal_full_right_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-nodpi/infobar_button_warning_full_left_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-nodpi/infobar_button_warning_full_left_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-nodpi/infobar_button_warning_full_right_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-nodpi/infobar_button_warning_full_right_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/infobar_button_normal_floating_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/infobar_button_normal_floating_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/infobar_button_warning_floating_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/infobar_button_warning_floating_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/infobar_dismiss.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/warning.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/infobar_blocked_popups.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/infobar_button_normal_floating_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/infobar_button_normal_floating_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/infobar_button_warning_floating_enabled.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/infobar_button_warning_floating_pressed.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/infobar_dismiss.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/infobar_update_uma.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/warning.png View Binary file 0 comments Download

Messages

Total messages: 8 (0 generated)
Miguel Garcia
7 years, 3 months ago (2013-09-06 08:59:29 UTC) #1
Miguel Garcia
The code that uses this is now also ready for review https://codereview.chromium.org/24109002/
7 years, 3 months ago (2013-09-16 12:12:04 UTC) #2
gone
I think there was some movement downstream to move the PNGs from drawable/ to drawable-mdpi/
7 years, 3 months ago (2013-09-16 17:29:07 UTC) #3
miguelg
Newton shall I move this stuff to drawable-mdpi/ then? I am not sure if this ...
7 years, 3 months ago (2013-09-16 17:39:57 UTC) #4
Yaron
On 2013/09/16 17:39:57, miguelg wrote: > Newton shall I move this stuff to drawable-mdpi/ then? ...
7 years, 3 months ago (2013-09-16 17:55:47 UTC) #5
gone
Will defer to Yaron's lgtm.
7 years, 3 months ago (2013-09-16 18:14:47 UTC) #6
newt (away)
Don't worry about moving resources yet. I'll move everything over once https://codereview.chromium.org/23944009/ lands. Thanks for ...
7 years, 3 months ago (2013-09-16 18:46:16 UTC) #7
Miguel Garcia
7 years, 3 months ago (2013-09-17 13:03:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r223599 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698