Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2395573004: Revert of Bluetooth: Disabling test due to leak. (Closed)

Created:
4 years, 2 months ago by gab
Modified:
4 years, 2 months ago
Reviewers:
Eric Caruso, Finnur
CC:
chromium-reviews, dbeam+watch-options_chromium.org, elijahtaylor+arcwatch_chromium.org, michaelpg+watch-options_chromium.org, yusukes+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, hidehiko+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bluetooth: Disabling test due to leak. (patchset #1 id:20001 of https://codereview.chromium.org/2394153002/ ) Reason for revert: CLs with leaks should be reverted, not their test disabled IMO: https://codereview.chromium.org/2389393005/ Original issue's description: > Bluetooth: Disabling test due to leak. > > TBR=ejcaruso > BUG=653480 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/c0b0d871d078b6615fc17fad42cd96ca1a118e62 > Cr-Commit-Position: refs/heads/master@{#423499} TBR=ejcaruso@chromium.org,finnur@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653480 Committed: https://crrev.com/5d4e1efc09097e67a2199f14423a4a4eb167b6e5 Cr-Commit-Position: refs/heads/master@{#423505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/arc/bluetooth/bluetooth_struct_traits_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
gab
Created Revert of Bluetooth: Disabling test due to leak.
4 years, 2 months ago (2016-10-06 13:18:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395573004/1
4 years, 2 months ago (2016-10-06 13:18:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 13:19:21 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 13:21:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d4e1efc09097e67a2199f14423a4a4eb167b6e5
Cr-Commit-Position: refs/heads/master@{#423505}

Powered by Google App Engine
This is Rietveld 408576698