Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2395563002: [heap] Use size_t throughout MemoryAllocator (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use size_t throughout MemoryAllocator BUG=chromium:652721 R=hpayer@chromium.org Committed: https://crrev.com/8b682e1a5ad1fcd15f989b17001b0dbc832cc98f Cr-Commit-Position: refs/heads/master@{#39986}

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : Fix compilation #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -83 lines) Patch
M src/extensions/statistics-extension.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/gc-tracer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 7 chunks +52 lines, -52 lines 1 comment Download
M src/heap/spaces.cc View 1 2 7 chunks +17 lines, -24 lines 0 comments Download
M src/regexp/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
Michael Lippautz
ptal
4 years, 2 months ago (2016-10-04 19:43:56 UTC) #3
Michael Lippautz
https://codereview.chromium.org/2395563002/diff/40001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2395563002/diff/40001/src/heap/spaces.h#newcode1240 src/heap/spaces.h:1240: static int CodePageGuardStartOffset(); Just moved up. size_t'ing these constants ...
4 years, 2 months ago (2016-10-04 19:44:50 UTC) #4
Hannes Payer (out of office)
lgtm
4 years, 2 months ago (2016-10-05 07:38:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395563002/40001
4 years, 2 months ago (2016-10-05 08:07:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25623)
4 years, 2 months ago (2016-10-05 08:13:08 UTC) #14
Michael Lippautz
+Yang for regepx owner
4 years, 2 months ago (2016-10-05 08:15:12 UTC) #16
Yang
On 2016/10/05 08:15:12, Michael Lippautz wrote: > +Yang for regepx owner lgtm.
4 years, 2 months ago (2016-10-05 10:37:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395563002/40001
4 years, 2 months ago (2016-10-05 10:38:24 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 10:40:19 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 10:40:42 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b682e1a5ad1fcd15f989b17001b0dbc832cc98f
Cr-Commit-Position: refs/heads/master@{#39986}

Powered by Google App Engine
This is Rietveld 408576698