Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2395543002: reflow comments in modules/[mediasource,plugins] (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
haraken, dcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, jkarlin+watch_chromium.org, blink-reviews, gyuyoung2, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in modules/[mediasource,plugins] BUG=563793 Committed: https://crrev.com/ebaaed67656c010067bd52ace76c1391302eaa05 Cr-Commit-Position: refs/heads/master@{#423050}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -220 lines) Patch
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 13 chunks +82 lines, -51 lines 2 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 35 chunks +300 lines, -144 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidators.h View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Nico
dcheng: review haraken: owners
4 years, 2 months ago (2016-10-04 18:55:29 UTC) #3
dcheng
LGTM (I don't really know what to do about the comments, I think it's fine ...
4 years, 2 months ago (2016-10-04 21:45:53 UTC) #9
haraken
LGTM
4 years, 2 months ago (2016-10-05 01:04:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395543002/1
4 years, 2 months ago (2016-10-05 02:14:01 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 02:19:25 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 02:21:18 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebaaed67656c010067bd52ace76c1391302eaa05
Cr-Commit-Position: refs/heads/master@{#423050}

Powered by Google App Engine
This is Rietveld 408576698