Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2395533003: [Sync] Move some things from driver to base. (Closed)

Created:
4 years, 2 months ago by maxbogue
Modified:
4 years, 2 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, yusukes+watch_chromium.org, droger+watchlist_chromium.org, michaelpg+watch-md-settings_chromium.org, tfarina, hidehiko+watch_chromium.org, sdefresne+watchlist_chromium.org, dbeam+watch-options_chromium.org, lhchavez+watch_chromium.org, sdefresne+watch_chromium.org, blundell+watchlist_chromium.org, mlamouri+watch-permissions_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, James Su, stevenjb+watch-md-settings_chromium.org, sync-reviews_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move some things from driver to base. Things moved: - invalidation_adapter - invalidation_helper - pref_names - report_unrecoverable_error (renamed from chrome_*) - sync_prefs - system_encryptor This CL was mostly generated by a script but required tweaking the SyncPrefs interface slightly to remove a dependency. BUG=631271 TBR=stuartmorgan,jochen Committed: https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422 Cr-Commit-Position: refs/heads/master@{#423773}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -1637 lines) Patch
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_uma_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/fake_server_invalidation_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/p2p_invalidation_forwarder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_components_factory_impl.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M components/browser_sync/profile_sync_service.h View 2 chunks +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M components/browser_sync/profile_sync_service_startup_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/BUILD.gn View 1 9 chunks +14 lines, -14 lines 0 comments Download
M components/sync/base/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A + components/sync/base/invalidation_adapter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/base/invalidation_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/base/invalidation_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/base/invalidation_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/base/pref_names.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/base/pref_names.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/base/report_unrecoverable_error.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/base/report_unrecoverable_error.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync/base/sync_prefs.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + components/sync/base/sync_prefs.cc View 3 chunks +10 lines, -16 lines 0 comments Download
A + components/sync/base/sync_prefs_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync/base/system_encryptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/base/system_encryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/base/system_encryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/fake_sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/sync/driver/glue/chrome_report_unrecoverable_error.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/sync/driver/glue/chrome_report_unrecoverable_error.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D components/sync/driver/invalidation_adapter.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/sync/driver/invalidation_adapter.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D components/sync/driver/invalidation_helper.h View 1 chunk +0 lines, -21 lines 0 comments Download
D components/sync/driver/invalidation_helper.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M components/sync/driver/model_type_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
D components/sync/driver/pref_names.h View 1 chunk +0 lines, -88 lines 0 comments Download
D components/sync/driver/pref_names.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M components/sync/driver/startup_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/startup_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/sync_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/sync_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/sync/driver/sync_prefs.h View 1 chunk +0 lines, -225 lines 0 comments Download
D components/sync/driver/sync_prefs.cc View 1 chunk +0 lines, -555 lines 0 comments Download
D components/sync/driver/sync_prefs_unittest.cc View 1 chunk +0 lines, -254 lines 0 comments Download
M components/sync/driver/sync_service_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/sync/driver/system_encryptor.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/sync/driver/system_encryptor.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D components/sync/driver/system_encryptor_unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M components/sync/tools/sync_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/sync/tools/sync_listen_notifications.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/sessions_sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/sync_setup_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (16 generated)
maxbogue
Pavel, PTAL!
4 years, 2 months ago (2016-10-05 18:55:59 UTC) #8
pavely
lgtm
4 years, 2 months ago (2016-10-07 00:13:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395533003/20001
4 years, 2 months ago (2016-10-07 00:23:34 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/276018)
4 years, 2 months ago (2016-10-07 00:34:15 UTC) #15
maxbogue
TBR jochen@ for chrome/ and stuartmorgan@ for ios/.
4 years, 2 months ago (2016-10-07 00:40:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395533003/20001
4 years, 2 months ago (2016-10-07 00:41:52 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 01:24:45 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422 Cr-Commit-Position: refs/heads/master@{#423773}
4 years, 2 months ago (2016-10-07 01:28:15 UTC) #24
stuartmorgan
4 years, 2 months ago (2016-10-12 22:29:45 UTC) #25
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698