Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/public/platform/WebRTCStats.h

Issue 2395503002: WebRTCStatsMember: Support for bool and sequence of bool (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebRTCStats.h
diff --git a/third_party/WebKit/public/platform/WebRTCStats.h b/third_party/WebKit/public/platform/WebRTCStats.h
index aeecfa0916eaa064dd6b106b5e36c2a8374a52ee..9ceab9673bde1d1c938e5de4d4b4d5076b816ced 100644
--- a/third_party/WebKit/public/platform/WebRTCStats.h
+++ b/third_party/WebKit/public/platform/WebRTCStats.h
@@ -19,6 +19,7 @@ class WebRTCStats;
class WebRTCStatsMember;
enum WebRTCStatsMemberType {
+ WebRTCStatsMemberTypeBool, // bool
WebRTCStatsMemberTypeInt32, // int32_t
WebRTCStatsMemberTypeUint32, // uint32_t
WebRTCStatsMemberTypeInt64, // int64_t
@@ -26,6 +27,7 @@ enum WebRTCStatsMemberType {
WebRTCStatsMemberTypeDouble, // double
WebRTCStatsMemberTypeString, // WebString
+ WebRTCStatsMemberTypeSequenceBool, // WebVector<int>
WebRTCStatsMemberTypeSequenceInt32, // WebVector<int32_t>
WebRTCStatsMemberTypeSequenceUint32, // WebVector<uint32_t>
WebRTCStatsMemberTypeSequenceInt64, // WebVector<int64_t>
@@ -70,12 +72,15 @@ class WebRTCStatsMember {
// Value getters. No conversion is performed; the function must match the
// member's |type|.
+ virtual bool valueBool() const = 0;
virtual int32_t valueInt32() const = 0;
virtual uint32_t valueUint32() const = 0;
virtual int64_t valueInt64() const = 0;
virtual uint64_t valueUint64() const = 0;
virtual double valueDouble() const = 0;
virtual WebString valueString() const = 0;
+ // |WebVector<int> because |WebVector| is incompatible with |bool|.
+ virtual WebVector<int> valueSequenceBool() const = 0;
virtual WebVector<int32_t> valueSequenceInt32() const = 0;
virtual WebVector<uint32_t> valueSequenceUint32() const = 0;
virtual WebVector<int64_t> valueSequenceInt64() const = 0;
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698