Fix buffer underflow bug in tab save state.

Fix buffer underflow bug in tab save state.

For Android JellyBean and older, there was a bug in
MappedByteBufferAdapter that caused ByteBuffer#rewind() to not be
propagated to the underlying buffer, causing buffer underflow when
the same buffer was read completely again to save the state. Fix is
to manually read the buffer rather than rely on rewind/remaining.

BUG=635744
Committed: https://crrev.com/cf9ab49008ec04279f157b4fa68f3ec814cc59dd
Cr-Commit-Position: refs/heads/master@{#422910}

[Peter Wen, 2016-10-04 15:13:22]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[Peter Wen, 2016-10-04 15:13:39]

wnwen@chromium.org changed reviewers:
+ andrhung@amazon.com

[Peter Wen, 2016-10-04 15:13:39]

Please take a look at this fix.

[commit-bot: I haz the power, 2016-10-04 15:13:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 15:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 15:57:07]

Dry run: This issue passed the CQ dry run.

[andrhung, 2016-10-04 16:56:13]

On 2016/10/04 15:13:39, Peter Wen wrote:
> Please take a look at this fix.

lgtm

[Peter Wen, 2016-10-04 18:24:29]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 18:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:36:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:36:18]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Wen, 2016-10-04 19:20:50]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[Peter Wen, 2016-10-04 19:21:18]

wnwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Peter Wen, 2016-10-04 19:21:18]

+dfalcantara for OWNERS.

[commit-bot: I haz the power, 2016-10-04 19:21:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-10-04 20:01:15]

lgtm

[commit-bot: I haz the power, 2016-10-04 20:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:12:03]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-10-04 20:23:09]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-10-04 20:23:10]

The patchset sent to the CQ was uploaded after l-g-t-m from andrhung@amazon.com
Link to the patchset: https://codereview.chromium.org/2395493002/#ps40001
(title: "Revert testing patch.")

[commit-bot: I haz the power, 2016-10-04 20:23:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:30:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 20:34:11]

Description was changed from

==========
Fix buffer underflow bug in tab save state.

For Android JellyBean and older, there was a bug in
MappedByteBufferAdapter that caused ByteBuffer#rewind() to not be
propagated to the underlying buffer, causing buffer underflow when
the same buffer was read completely again to save the state. Fix is
to manually read the buffer rather than rely on rewind/remaining.

BUG=635744
==========

to

==========
Fix buffer underflow bug in tab save state.

For Android JellyBean and older, there was a bug in
MappedByteBufferAdapter that caused ByteBuffer#rewind() to not be
propagated to the underlying buffer, causing buffer underflow when
the same buffer was read completely again to save the state. Fix is
to manually read the buffer rather than rely on rewind/remaining.

BUG=635744

Committed: https://crrev.com/cf9ab49008ec04279f157b4fa68f3ec814cc59dd
Cr-Commit-Position: refs/heads/master@{#422910}
==========

[commit-bot: I haz the power, 2016-10-04 20:34:12]

Patchset 3 (id:??) landed as
https://crrev.com/cf9ab49008ec04279f157b4fa68f3ec814cc59dd
Cr-Commit-Position: refs/heads/master@{#422910}