Allow top_sites to be null.

Allow top_sites to be null.

iOS wants it for tests. Everywhere we use top_sites_, we check for its
non-null-ness.

BUG=631990
Committed: https://crrev.com/aa1b88660791976daa2ece8873b8ac87fc8dfc67
Cr-Commit-Position: refs/heads/master@{#422821}

[sfiera, 2016-10-04 14:52:58]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2016-10-04 15:02:58]

lgtm

Hm. TBH I'd be happier if we could keep the non-null requirement, remove the
null checks, and pass in a fake or mock or whatever is appropriate for those
tests. LGTM if this is blocking you, but please put a comment where the
"DCHECK(top_sites_)" was. ("can be null in tests", maybe a TODO to change that?)

[sfiera, 2016-10-04 15:21:19]

Done.

[sfiera, 2016-10-04 15:21:23]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-10-04 15:21:23]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2395483002/#ps20001
(title: "Add comment/TODO.")

[commit-bot: I haz the power, 2016-10-04 15:21:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 16:09:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 16:11:28]

Description was changed from

==========
Allow top_sites to be null.

iOS wants it for tests. Everywhere we use top_sites_, we check for its
non-null-ness.

BUG=631990
==========

to

==========
Allow top_sites to be null.

iOS wants it for tests. Everywhere we use top_sites_, we check for its
non-null-ness.

BUG=631990

Committed: https://crrev.com/aa1b88660791976daa2ece8873b8ac87fc8dfc67
Cr-Commit-Position: refs/heads/master@{#422821}
==========

[commit-bot: I haz the power, 2016-10-04 16:11:29]

Patchset 2 (id:??) landed as
https://crrev.com/aa1b88660791976daa2ece8873b8ac87fc8dfc67
Cr-Commit-Position: refs/heads/master@{#422821}