[stubs] Add String and JSReceiver instance type predicates

src/builtins/builtins-array.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/code-factory.h"
 #include "src/elements.h"
 
@@ skipping 1392 matching lines @@
     assembler->GotoIf(assembler->WordEqual(search_element, undefined),
                       &undef_loop);
     Node* map = assembler->LoadMap(search_element);
     assembler->GotoIf(assembler->WordNotEqual(map, heap_number_map),
                       &not_heap_num);
     search_num.Bind(assembler->LoadHeapNumberValue(search_element));
     assembler->Goto(&heap_num_loop);
 
     assembler->Bind(&not_heap_num);
     Node* search_type = assembler->LoadMapInstanceType(map);
-    assembler->GotoIf(
-        assembler->Int32LessThan(
-            search_type, assembler->Int32Constant(FIRST_NONSTRING_TYPE)),
-        &string_loop);
+    assembler->GotoIf(assembler->IsStringInstanceType(search_type),
+                      &string_loop);
     assembler->GotoIf(
         assembler->Word32Equal(search_type,
                                assembler->Int32Constant(SIMD128_VALUE_TYPE)),
         &simd_loop);
     assembler->Goto(&ident_loop);
 
     assembler->Bind(&ident_loop);
     {
       assembler->GotoUnless(
           assembler->UintPtrLessThan(index_var.value(), len_var.value()),
@@ skipping 83 matching lines @@
 
     assembler->Bind(&string_loop);
     {
       Label continue_loop(assembler);
       assembler->GotoUnless(
           assembler->UintPtrLessThan(index_var.value(), len_var.value()),
           &return_false);
       Node* element_k = assembler->LoadFixedArrayElement(
           elements, index_var.value(), 0, CodeStubAssembler::INTPTR_PARAMETERS);
       assembler->GotoIf(assembler->WordIsSmi(element_k), &continue_loop);
-      assembler->GotoUnless(assembler->Int32LessThan(
-                                assembler->LoadInstanceType(element_k),
-                                assembler->Int32Constant(FIRST_NONSTRING_TYPE)),
+      assembler->GotoUnless(assembler->IsStringInstanceType(
+                                assembler->LoadInstanceType(element_k)),
                             &continue_loop);
 
       // TODO(bmeurer): Consider inlining the StringEqual logic here.
       Callable callable = CodeFactory::StringEqual(assembler->isolate());
       Node* result =
           assembler->CallStub(callable, context, search_element, element_k);
       assembler->Branch(
           assembler->WordEqual(assembler->BooleanConstant(true), result),
           &return_true, &continue_loop);
 
@@ skipping 315 matching lines @@
     assembler->GotoIf(assembler->WordEqual(search_element, undefined),
                       &undef_loop);
     Node* map = assembler->LoadMap(search_element);
     assembler->GotoIf(assembler->WordNotEqual(map, heap_number_map),
                       &not_heap_num);
     search_num.Bind(assembler->LoadHeapNumberValue(search_element));
     assembler->Goto(&heap_num_loop);
 
     assembler->Bind(&not_heap_num);
     Node* search_type = assembler->LoadMapInstanceType(map);
-    assembler->GotoIf(
-        assembler->Int32LessThan(
-            search_type, assembler->Int32Constant(FIRST_NONSTRING_TYPE)),
-        &string_loop);
+    assembler->GotoIf(assembler->IsStringInstanceType(search_type),
+                      &string_loop);
     assembler->GotoIf(
         assembler->Word32Equal(search_type,
                                assembler->Int32Constant(SIMD128_VALUE_TYPE)),
         &simd_loop);
     assembler->Goto(&ident_loop);
 
     assembler->Bind(&ident_loop);
     {
       assembler->GotoUnless(
           assembler->UintPtrLessThan(index_var.value(), len_var.value()),
@@ skipping 58 matching lines @@
 
     assembler->Bind(&string_loop);
     {
       Label continue_loop(assembler);
       assembler->GotoUnless(
           assembler->UintPtrLessThan(index_var.value(), len_var.value()),
           &return_not_found);
       Node* element_k = assembler->LoadFixedArrayElement(
           elements, index_var.value(), 0, CodeStubAssembler::INTPTR_PARAMETERS);
       assembler->GotoIf(assembler->WordIsSmi(element_k), &continue_loop);
-      assembler->GotoUnless(assembler->Int32LessThan(
-                                assembler->LoadInstanceType(element_k),
-                                assembler->Int32Constant(FIRST_NONSTRING_TYPE)),
+      assembler->GotoUnless(assembler->IsStringInstanceType(
+                                assembler->LoadInstanceType(element_k)),
                             &continue_loop);
 
       // TODO(bmeurer): Consider inlining the StringEqual logic here.
       Callable callable = CodeFactory::StringEqual(assembler->isolate());
       Node* result =
           assembler->CallStub(callable, context, search_element, element_k);
       assembler->Branch(
           assembler->WordEqual(assembler->BooleanConstant(true), result),
           &return_found, &continue_loop);
 
@@ skipping 111 matching lines @@
   assembler->Bind(&return_not_found);
   assembler->Return(assembler->NumberConstant(-1));
 
   assembler->Bind(&call_runtime);
   assembler->Return(assembler->CallRuntime(Runtime::kArrayIndexOf, context,
                                            array, search_element, start_from));
 }
 
 }  // namespace internal
 }  // namespace v8