Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 239543013: Work on Mac GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix line endings Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 280fccd93a5a3df86c52dd5003ca24e1bc225648..7f8059577b49077128c2347953076a79cadea042 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -42,10 +42,6 @@ declare_args() {
# the default toolchain to 64-bit.
force_win64 = false
- # Set to true on the command line when invoked by GYP. Build files can key
- # off of this to make any GYP-output-specific changes to the build.
- is_gyp = false
-
# Selects the desired build flavor. Official builds get additional
# processing to prepare for release. Normally you will want to develop and
# test with this flag off.
@@ -67,13 +63,6 @@ declare_args() {
# Compile for Thread Sanitizer to find threading bugs.
is_tsan = false
-
- # When running in gyp-generating mode, this is the root of the build tree.
- gyp_output_dir = "out"
-
- # When running in gyp-generating mode, this flag indicates if the current GYP
- # generator is xcode. Can only be true when building for iOS).
- is_gyp_xcode_generator = false
}
# =============================================================================
@@ -365,7 +354,10 @@ if (!is_win) {
native_compiler_configs += [ "//build/config/gcc:symbol_visibility_hidden" ]
}
if (is_clang) {
- native_compiler_configs += [ "//build/config/clang:find_bad_constructs" ]
+ native_compiler_configs += [
+ "//build/config/clang:find_bad_constructs",
+ "//build/config/clang:extra_warnings",
+ ]
}
# Optimizations and debug checking.
« no previous file with comments | « build/config/BUILD.gn ('k') | build/config/clang/BUILD.gn » ('j') | skia/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698