Chromium Code Reviews| Index: extensions/extensions_strings.gyp |
| diff --git a/components/components_strings.gyp b/extensions/extensions_strings.gyp |
| similarity index 54% |
| copy from components/components_strings.gyp |
| copy to extensions/extensions_strings.gyp |
| index 72555e79b16d19a380fe6222d3f926d0aeb5afdd..3dc11029a1dbb806abdc6de8bfc4ca96967ce795 100644 |
| --- a/components/components_strings.gyp |
| +++ b/extensions/extensions_strings.gyp |
| @@ -5,23 +5,25 @@ |
| { |
| 'targets': [ |
| { |
| - 'target_name': 'components_strings', |
| + 'target_name': 'extensions_strings', |
| 'type': 'none', |
| 'actions': [ |
| { |
| - 'action_name': 'generate_components_strings', |
| + 'action_name': 'generate_extensions_strings', |
| 'variables': { |
| - 'grit_grd_file': 'components_strings.grd', |
| - 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/components/strings', |
| + 'grit_grd_file': 'extensions_strings.grd', |
| + 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/extensions_strings', |
| }, |
| 'includes': [ '../build/grit_action.gypi' ], |
| }, |
| ], |
| 'direct_dependent_settings': { |
| 'include_dirs': [ |
| - '<(SHARED_INTERMEDIATE_DIR)/components/strings', |
| + '<(SHARED_INTERMEDIATE_DIR)/extensions_strings', |
|
tfarina
2014/04/16 16:08:12
did you deliberated choose not to use the path (ex
James Cook
2014/04/16 16:22:35
No good reason. Done.
|
| ], |
| }, |
| + # This target generates extensions_strings.h so it must build before |
|
tfarina
2014/04/16 16:08:12
My English is not all that good, but is it incorre
James Cook
2014/04/16 16:22:35
Done. Both are correct but your version sounds bet
|
| + # targets that depend on it. |
| 'hard_dependency': 1, |
| }, |
| ], |