Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: extensions/extensions_strings.gyp

Issue 239543005: Introduce extensions_strings.grd (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: hard dependency Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « extensions/extensions_strings.grd ('k') | extensions/strings/extensions_strings_am.xtb » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'components_strings', 8 'target_name': 'extensions_strings',
9 'type': 'none', 9 'type': 'none',
10 'actions': [ 10 'actions': [
11 { 11 {
12 'action_name': 'generate_components_strings', 12 'action_name': 'generate_extensions_strings',
13 'variables': { 13 'variables': {
14 'grit_grd_file': 'components_strings.grd', 14 'grit_grd_file': 'extensions_strings.grd',
15 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/components/strings', 15 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/extensions_strings',
16 }, 16 },
17 'includes': [ '../build/grit_action.gypi' ], 17 'includes': [ '../build/grit_action.gypi' ],
18 }, 18 },
19 ], 19 ],
20 'direct_dependent_settings': { 20 'direct_dependent_settings': {
21 'include_dirs': [ 21 'include_dirs': [
22 '<(SHARED_INTERMEDIATE_DIR)/components/strings', 22 '<(SHARED_INTERMEDIATE_DIR)/extensions_strings',
tfarina 2014/04/16 16:08:12 did you deliberated choose not to use the path (ex
James Cook 2014/04/16 16:22:35 No good reason. Done.
23 ], 23 ],
24 }, 24 },
25 # This target generates extensions_strings.h so it must build before
tfarina 2014/04/16 16:08:12 My English is not all that good, but is it incorre
James Cook 2014/04/16 16:22:35 Done. Both are correct but your version sounds bet
26 # targets that depend on it.
25 'hard_dependency': 1, 27 'hard_dependency': 1,
26 }, 28 },
27 ], 29 ],
28 } 30 }
OLDNEW
« no previous file with comments | « extensions/extensions_strings.grd ('k') | extensions/strings/extensions_strings_am.xtb » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698