Introduce extensions_strings.grd

extensions/extensions.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
       'target_name': 'extensions_common',
       'type': 'static_library',
       'dependencies': [
-        'common/api/api.gyp:extensions_api',
         # TODO(benwells): figure out what to do with the api target and
         # api resources compiled into the chrome resource bundle.
         # http://crbug.com/162530
         '../chrome/chrome_resources.gyp:chrome_resources',
-        # TODO(jamescook|derat): Pull strings into extensions module.
+        # TODO(jamescook|derat): Pull all strings into extensions module.
         '../chrome/chrome_resources.gyp:chrome_strings',
         # Need default icons in theme_resources.grd
         '../chrome/chrome_resources.gyp:theme_resources',
 
         # TODO(tfarina): This dep here is for extensions/common/constants.*
         # We should find a way to compile this module within extensions_common.
         '../chrome/common_constants.gyp:common_constants',
         '../components/components.gyp:url_matcher',
         '../content/content.gyp:content_common',
         '../crypto/crypto.gyp:crypto',
         '../ipc/ipc.gyp:ipc',
         '../net/net.gyp:net',
         '../third_party/re2/re2.gyp:re2',
         '../ui/base/ui_base.gyp:ui_base',
         '../ui/gfx/gfx.gyp:gfx_geometry',
         '../url/url.gyp:url_lib',
+        'common/api/api.gyp:extensions_api',

[James Cook, 2014/04/15 23:46:39]

I sorted this so everything is alphabetical.

+        'extensions_strings.gyp:extensions_strings',
       ],
       'include_dirs': [
         '..',
         '<(INTERMEDIATE_DIR)',
       ],
       'sources': [
         'common/api/messaging/message.h',
         'common/api/sockets/sockets_manifest_data.cc',
         'common/api/sockets/sockets_manifest_data.h',
         'common/api/sockets/sockets_manifest_handler.cc',
@@ skipping 162 matching lines @@
           'sources!': [
             'common/extension_api.cc',
           ],
         }],
       ],
     },
     {
       'target_name': 'extensions_browser',
       'type': 'static_library',
       'dependencies': [
-        'extensions_common',
-        'common/api/api.gyp:extensions_api',
         # TODO(jamescook|derat): Pull strings into extensions module.
         '../chrome/chrome_resources.gyp:chrome_strings',
         '../components/components.gyp:keyed_service_content',
         '../content/content.gyp:content_browser',
         '../skia/skia.gyp:skia',
         '../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
+        'common/api/api.gyp:extensions_api',
+        'extensions_common',
+        'extensions_strings.gyp:extensions_strings',
       ],
       'include_dirs': [
         '..',
         '<(INTERMEDIATE_DIR)',
         # Needed to access generated API headers.
         '<(SHARED_INTERMEDIATE_DIR)',
         # Needed for grit.
         '<(SHARED_INTERMEDIATE_DIR)/chrome',
       ],
       'sources': [
@@ skipping 196 matching lines @@
       'dependencies': [
         '../third_party/WebKit/public/blink.gyp:blink',
       ],
       # Disable c4267 warnings until we fix size_t to int truncations.
       'msvs_disabled_warnings': [ 4267, ],
     },
     {
       'target_name': 'extensions_test_support',
       'type': 'static_library',
       'dependencies': [
+        '../base/base.gyp:base',
+        '../testing/gtest.gyp:gtest',
         'extensions_browser',
         'extensions_common',
-        '../base/base.gyp:base',
-        '../testing/gtest.gyp:gtest',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'browser/test_extensions_browser_client.cc',
         'browser/test_extensions_browser_client.h',
         'browser/test_management_policy.cc',
         'browser/test_management_policy.h',
         'common/extension_builder.cc',
@@ skipping 12 matching lines @@
       # after that we will start the work on buildbot to get this running there.
       # When we consider this stable in the bots, we can go to unit_tests target
       # and remove the duplicated entries from there, otherwise if we just
       # remove them right now we would be losing coverage.
       # http://crbug.com/348066
       'target_name': 'extensions_unittests',
       'type': 'executable',
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:test_support_base',
+        '../testing/gmock.gyp:gmock',

[James Cook, 2014/04/15 23:46:39]

I missed this before -- a couple tests below use gmock.

         '../testing/gtest.gyp:gtest',
         'extensions_common',
+        'extensions_strings.gyp:extensions_strings',
         'extensions_test_support',
       ],
       'sources': [
         'common/api/sockets/sockets_manifest_permission_unittest.cc',
         'common/csp_validator_unittest.cc',
         'common/event_filter_unittest.cc',
         'common/file_util_unittest.cc',
         'common/id_util_unittest.cc',
         'common/manifest_handler_unittest.cc',
         'common/one_shot_event_unittest.cc',
         'common/permissions/api_permission_set_unittest.cc',
         'common/permissions/manifest_permission_set_unittest.cc',
         'common/url_pattern_set_unittest.cc',
         'common/url_pattern_unittest.cc',
         'common/user_script_unittest.cc',
         'test/extensions_unittests_main.cc',
         'test/test_extensions_client.cc',
         'test/test_extensions_client.h',
         'test/test_permission_message_provider.cc',
         'test/test_permission_message_provider.h',
         'test/test_permissions_provider.cc',
         'test/test_permissions_provider.h',
       ],
     },
   ]
 }