Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2395393003: Remove grow box rect support, renderer part. (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove grow box rect support, renderer part. Depends on https://codereview.chromium.org/2400243002/ The grow box was always (0, 0, 0, 0) in practice, which means all this code was a no-op. BUG=653271 Committed: https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317 Cr-Commit-Position: refs/heads/master@{#424145}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : more #

Patch Set 6 : . #

Total comments: 3

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -178 lines) Patch
M components/printing/test/print_web_view_helper_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/common/resize_params.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/test/render_view_test.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 6 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/render_widget_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 2 3 4 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 10 chunks +2 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebWidgetClient.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (21 generated)
Nico
https://codereview.chromium.org/2395393003/diff/90001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (left): https://codereview.chromium.org/2395393003/diff/90001/content/renderer/render_widget.cc#oldcode516 content/renderer/render_widget.cc:516: IPC_MESSAGE_HANDLER(ViewMsg_ChangeResizeRect, OnChangeResizeRect) Nothing ever sends this after the browser-side ...
4 years, 2 months ago (2016-10-07 17:27:26 UTC) #7
Nico
jochen: ping
4 years, 2 months ago (2016-10-10 12:08:53 UTC) #14
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-10 12:31:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395393003/110001
4 years, 2 months ago (2016-10-10 13:33:18 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/277427)
4 years, 2 months ago (2016-10-10 13:42:29 UTC) #22
Nico
rsesek: ipc owners for view_messages.h
4 years, 2 months ago (2016-10-10 13:48:07 UTC) #24
Robert Sesek
messages lgtm
4 years, 2 months ago (2016-10-10 14:00:51 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395393003/110001
4 years, 2 months ago (2016-10-10 14:03:58 UTC) #27
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 2 months ago (2016-10-10 14:09:37 UTC) #29
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 14:12:03 UTC) #31
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317
Cr-Commit-Position: refs/heads/master@{#424145}

Powered by Google App Engine
This is Rietveld 408576698