Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2395393002: Prune deprecated functions from ReplaceSelectionCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune deprecated functions from ReplaceSelectionCommand BUG=647219, 651373 Committed: https://crrev.com/908c1a145ab363b72a7053d5de31bde47939dc81 Cr-Commit-Position: refs/heads/master@{#423830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -69 lines) Patch
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 31 chunks +94 lines, -69 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-07 09:44:51 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-07 09:57:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395393002/1
4 years, 2 months ago (2016-10-07 09:57:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 10:07:16 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 10:09:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/908c1a145ab363b72a7053d5de31bde47939dc81
Cr-Commit-Position: refs/heads/master@{#423830}

Powered by Google App Engine
This is Rietveld 408576698