Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issue 2395373002: [builtins] Migrate Number.parseFloat to a TurboFan builtin. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate Number.parseFloat to a TurboFan builtin. This implicitly convers parseFloat on the global object as well, since it's the same function. This is mostly straight-forward, but adds another fast case for HeapNumbers as well. R=ishell@chromium.org Committed: https://crrev.com/0f7f6e33ba131616325857ad1edd4a62d577693f Cr-Commit-Position: refs/heads/master@{#40072}

Patch Set 1 #

Patch Set 2 : Fix the -0 corner case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -13 lines) Patch
M src/bootstrapper.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-number.cc View 1 1 chunk +106 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +0 lines, -11 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-07 07:47:31 UTC) #1
Igor Sheludko
lgtm
4 years, 2 months ago (2016-10-07 08:30:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395373002/20001
4 years, 2 months ago (2016-10-07 08:34:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 08:58:48 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 08:59:07 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f7f6e33ba131616325857ad1edd4a62d577693f
Cr-Commit-Position: refs/heads/master@{#40072}

Powered by Google App Engine
This is Rietveld 408576698