Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2395363002: Add storage_unittests to buildbots. (Closed)

Created:
4 years, 2 months ago by pwnall
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add storage_unittests to buildbots. BUG=653751 Committed: https://crrev.com/008c02729b10638f42f3598272bd30342d194a42 Cr-Commit-Position: refs/heads/master@{#425361}

Patch Set 1 : Include BUILD.gn changes. #

Patch Set 2 : Rebased against master. #

Patch Set 3 : Rebased against master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -0 lines) Patch
M BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.android.json View 1 2 10 chunks +143 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.full.json View 8 chunks +29 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 10 chunks +67 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 6 chunks +58 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +25 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.full.json View 8 chunks +29 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 8 chunks +29 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 56 (39 generated)
pwnall
thakis@: Can you please review the changes to build/android/pylib/gtest/gtest_config.py? phajdan.jr@: Can you please review everything ...
4 years, 2 months ago (2016-10-11 03:40:48 UTC) #14
Paweł Hajdan Jr.
LGTM
4 years, 2 months ago (2016-10-11 18:22:54 UTC) #19
pwnall
mikecase@chromium.org: Please review changes in build/android/pylib/gtest/gtest_config.py I switched out thakis@ because he recently updated his ...
4 years, 2 months ago (2016-10-12 04:37:36 UTC) #22
mikecase (-- gone --)
lgtm
4 years, 2 months ago (2016-10-13 20:49:27 UTC) #23
pwnall
On 2016/10/11 18:22:54, Paweł Hajdan Jr. wrote: > LGTM Thank you very much for the ...
4 years, 2 months ago (2016-10-13 22:01:02 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395363002/60001
4 years, 2 months ago (2016-10-13 22:01:06 UTC) #26
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-13 22:04:33 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395363002/80001
4 years, 2 months ago (2016-10-13 23:54:11 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/280895)
4 years, 2 months ago (2016-10-14 00:00:52 UTC) #37
pwnall
scottmg: Can you please review the changes to BUILD.gn? https://codereview.chromium.org/2395363002/diff/80001/BUILD.gn Thank you very much!
4 years, 2 months ago (2016-10-14 00:26:53 UTC) #39
scottmg
build lgtm
4 years, 2 months ago (2016-10-14 15:11:33 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395363002/80001
4 years, 2 months ago (2016-10-14 15:18:52 UTC) #42
pwnall
On 2016/10/14 15:11:33, scottmg wrote: > build lgtm Thank you very much for getting back ...
4 years, 2 months ago (2016-10-14 15:19:02 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/281357)
4 years, 2 months ago (2016-10-14 15:30:06 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395363002/100001
4 years, 2 months ago (2016-10-14 16:46:33 UTC) #52
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 2 months ago (2016-10-14 16:54:31 UTC) #54
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:56:47 UTC) #56
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/008c02729b10638f42f3598272bd30342d194a42
Cr-Commit-Position: refs/heads/master@{#425361}

Powered by Google App Engine
This is Rietveld 408576698