Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2395333002: [DevTools] Support top/bottom show sidebar button. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support top/bottom show sidebar button. BUG=651705 Committed: https://crrev.com/35bb5043ed9e6f455d3c725d755ebfc76b53cf2b Cr-Commit-Position: refs/heads/master@{#423998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -23 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 6 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesView.css View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please!
4 years, 2 months ago (2016-10-06 23:35:19 UTC) #2
lushnikov
lgtm
4 years, 2 months ago (2016-10-07 21:09:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395333002/1
4 years, 2 months ago (2016-10-07 21:10:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 22:57:56 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 23:01:03 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/35bb5043ed9e6f455d3c725d755ebfc76b53cf2b
Cr-Commit-Position: refs/heads/master@{#423998}

Powered by Google App Engine
This is Rietveld 408576698