Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 239533002: Combine settings about compositing scrollable frames (Closed)

Created:
6 years, 8 months ago by Xianzhu
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Combine settings about compositing scrollable frames Combine acceleratedCompositingForScrollableFramesEnabled and compositedScrollingForFramesEnabled. They are always enabled or disabled together. Now they are always enabled on Android. On other platforms, they will be automatically enabled when forceCompositingMode is true on HDPI devices. BUG=304900 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M LayoutTests/compositing/force-compositing-mode/force-composite-empty.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/no-overflow-iframe-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-iframe-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/iframes/iframe-composited-scrolling.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/tests/CompositedLayerMappingTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Xianzhu
6 years, 8 months ago (2014-04-15 17:39:27 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-15 17:54:12 UTC) #2
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 8 months ago (2014-04-15 18:04:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/239533002/1
6 years, 8 months ago (2014-04-15 18:04:35 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 18:40:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-15 18:40:27 UTC) #6
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 8 months ago (2014-04-15 19:18:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/239533002/1
6 years, 8 months ago (2014-04-15 19:19:01 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 19:51:49 UTC) #9
Message was sent while issue was closed. 
Change committed as 171685

Powered by Google App Engine
This is Rietveld 408576698