Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client_unittest.cc

Issue 2395323002: Roll src/third_party/boringssl/src 0d81373f9..1991af690 (Closed)
Patch Set: rebase, roll further Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc b/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
index 3f6ed9da8d213076deb21894c32858068857ba93..3e933364457064fd3cf7ab5bb2486ccbec68b455 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
@@ -191,6 +191,26 @@ TEST(ChromeSecurityStateModelClientTest, ConnectionExplanation) {
"strong cipher (CHACHA20_POLY1305).",
explanation.description);
}
+
+ // TLS 1.3 ciphers use the key exchange group exclusively.
+ net::SSLConnectionStatusSetCipherSuite(0x1301 /* TLS_AES_128_GCM_SHA256 */,
+ &security_info.connection_status);
+ net::SSLConnectionStatusSetVersion(net::SSL_CONNECTION_VERSION_TLS1_3,
+ &security_info.connection_status);
+ security_info.key_exchange_group = 29; // X25519
+ {
+ content::SecurityStyleExplanations explanations;
+ ChromeSecurityStateModelClient::GetSecurityStyle(security_info,
+ &explanations);
+ content::SecurityStyleExplanation explanation;
+ ASSERT_TRUE(FindSecurityStyleExplanation(
+ explanations.secure_explanations, "Secure Connection", &explanation));
+ EXPECT_EQ(
+ "The connection to this site is encrypted and authenticated using a "
+ "strong protocol (TLS 1.3), a strong key exchange (X25519), and a "
+ "strong cipher (AES_128_GCM).",
+ explanation.description);
+ }
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698