Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: net/socket/ssl_server_socket_unittest.cc

Issue 2395323002: Roll src/third_party/boringssl/src 0d81373f9..1991af690 (Closed)
Patch Set: roll further, fix things Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_server_socket_unittest.cc
diff --git a/net/socket/ssl_server_socket_unittest.cc b/net/socket/ssl_server_socket_unittest.cc
index e3e242f8f0d6d31faa744f4d47677455e7ed4d3e..369f0029db7657976e2dabce6442c670c6544cd8 100644
--- a/net/socket/ssl_server_socket_unittest.cc
+++ b/net/socket/ssl_server_socket_unittest.cc
@@ -550,17 +550,19 @@ TEST_F(SSLServerSocketTest, Handshake) {
ASSERT_TRUE(client_socket_->GetSSLInfo(&ssl_info));
EXPECT_EQ(CERT_STATUS_AUTHORITY_INVALID, ssl_info.cert_status);
- // The default cipher suite should be ECDHE and, unless on NSS and the
- // platform doesn't support it, an AEAD.
+ // The default cipher suite should be ECDHE and an AEAD.
uint16_t cipher_suite =
SSLConnectionStatusToCipherSuite(ssl_info.connection_status);
const char* key_exchange;
const char* cipher;
const char* mac;
bool is_aead;
- SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, cipher_suite);
- EXPECT_STREQ("ECDHE_RSA", key_exchange);
+ bool is_tls13;
+ SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, &is_tls13,
+ cipher_suite);
EXPECT_TRUE(is_aead);
+ ASSERT_FALSE(is_tls13);
+ EXPECT_STREQ("ECDHE_RSA", key_exchange);
}
// This test makes sure the session cache is working.

Powered by Google App Engine
This is Rietveld 408576698