Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6976)

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2395323002: Roll src/third_party/boringssl/src 0d81373f9..1991af690 (Closed)
Patch Set: roll further, fix things Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index af83e2f2b6c3e81434b7b82dd538b0e5e2ddf644..6ae09c5f933e8218b7e775aa8b05211361c488eb 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/website_settings/website_settings.h"
+#include <openssl/ssl.h>
#include <stddef.h>
#include <stdint.h>
@@ -638,12 +639,21 @@ void WebsiteSettings::Init(
(security_info.connection_status &
net::SSL_CONNECTION_NO_RENEGOTIATION_EXTENSION) != 0;
const char *key_exchange, *cipher, *mac;
- bool is_aead;
- net::SSLCipherSuiteToStrings(
- &key_exchange, &cipher, &mac, &is_aead, cipher_suite);
+ bool is_aead, is_tls13;
+ net::SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead,
+ &is_tls13, cipher_suite);
site_connection_details_ += ASCIIToUTF16("\n\n");
if (is_aead) {
+ if (is_tls13) {
+ // For TLS 1.3 ciphers, report the group (historically, curve) as the
+ // key exchange.
+ key_exchange = SSL_get_curve_name(security_info.key_exchange_group);
+ if (!key_exchange) {
+ NOTREACHED();
+ key_exchange = "";
+ }
+ }
site_connection_details_ += l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTION_DETAILS_AEAD,
ASCIIToUTF16(cipher), ASCIIToUTF16(key_exchange));

Powered by Google App Engine
This is Rietveld 408576698