Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2395303002: Scale Stack Limits in ThreadTest.StartWithOptions_StackSize with Bitness (Closed)

Created:
4 years, 2 months ago by robliao
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, M-A Ruel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scale Stack Limits in ThreadTest.StartWithOptions_StackSize with Bitness 12 kb may be too small for a 64-bit machine. This allows enough breathing space for the thread local storage teardown later on. BUG=590907 Committed: https://crrev.com/745d6044a0560f4470e005f1a92543f889600323 Cr-Commit-Position: refs/heads/master@{#423710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M base/threading/thread_unittest.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
robliao
4 years, 2 months ago (2016-10-06 22:00:22 UTC) #4
dcheng
lgtm
4 years, 2 months ago (2016-10-06 22:08:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395303002/1
4 years, 2 months ago (2016-10-06 22:14:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 22:21:15 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 22:23:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/745d6044a0560f4470e005f1a92543f889600323
Cr-Commit-Position: refs/heads/master@{#423710}

Powered by Google App Engine
This is Rietveld 408576698